[webkit-reviews] review denied: [Bug 79738] [Qt] Authentication dialog does not work : [Attachment 130628] Updated Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Dinu Jacob
<dinu.jacob at Nokia.com>'s request for review:
Bug 79738: [Qt] Authentication dialog does not work
https://bugs.webkit.org/show_bug.cgi?id=79738

Attachment 130628: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=130628&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130628&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:285
> +    dialogRunner = new QtDialogRunner;

This should use an OwnPtr and you should make a PassOwnPtr
QtDialogRunner::create()

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:518
> +void QQuickWebViewPrivate::destroyDialogRunner()
> +{
> +    delete dialogRunner;
> +    dialogRunner = 0;
> +}

ieck! this calls for an OwnPtr