[webkit-reviews] review granted: [Bug 80448] [BlackBerry] WebKit rendering problem when show/hide VKB : [Attachment 130630] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Jacky Jiang
<zkjiang008 at gmail.com>'s request for review:
Bug 80448: [BlackBerry] WebKit rendering problem when show/hide VKB
https://bugs.webkit.org/show_bug.cgi?id=80448

Attachment 130630: Patch
https://bugs.webkit.org/attachment.cgi?id=130630&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130630&action=review


> Source/WebKit/blackberry/ChangeLog:14
> +
> +	   When setting viewport size, layout happens inside
> +	   WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is
> +	   outside of the code path of "needsLayout" so that the contents are
> +	   not rendered into the backing store. This is a regression of
r108718,
> +	   switch back to do the layout inside the public API
> +	   WebPage::setDefaultLayoutSize().

it worries me very my that WebPage::xxx does more than WebPagePrivate:xxx
methods :/

please lets fix this in a follow up.