[webkit-reviews] review denied: [Bug 80502] Editing caret should skip elements with shadow dom. : [Attachment 130576] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 08:54:29 PST 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Hajime Morrita
<morrita at google.com>'s request for review:
Bug 80502: Editing caret should skip elements with shadow dom.
https://bugs.webkit.org/show_bug.cgi?id=80502

Attachment 130576: Patch
https://bugs.webkit.org/attachment.cgi?id=130576&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130576&action=review


>> Source/WebCore/html/HTMLDetailsElement.cpp:163
>> +	return 1 == shadowTree()->size();
> 
> I don't understand. Why it's okay for selection to be inside the light dom
when there are more than 1 shadow trees?

I don't understand either :) IMG, VIDEO, and AUDIO all have the content not
distributed?


More information about the webkit-reviews mailing list