[webkit-reviews] review granted: [Bug 77245] [Chromium] SVG Composite of Offset crashes : [Attachment 130196] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 14:33:54 PST 2012


Stephen White <senorblanco at chromium.org> has granted Stephen Chenney
<schenney at chromium.org>'s request for review:
Bug 77245: [Chromium] SVG Composite of Offset crashes
https://bugs.webkit.org/show_bug.cgi?id=77245

Attachment 130196: Patch
https://bugs.webkit.org/attachment.cgi?id=130196&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130196&action=review


Looks good.  r=me

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:119
> +void FilterEffect::forceValidPreMultipliedPixels()

Nit:  It looks like the guts of this function could potentially live in
FEComposite::correctFilterResultIfNeeded, since it's the only caller.  Not a
big deal, though.


More information about the webkit-reviews mailing list