[webkit-reviews] review granted: [Bug 80250] [JSC] Cache the CSSPropertyID in JSCSSStyleDeclaration for performance optimization : [Attachment 130082] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 80250: [JSC] Cache the CSSPropertyID in JSCSSStyleDeclaration for
performance optimization
https://bugs.webkit.org/show_bug.cgi?id=80250

Attachment 130082: Patch
https://bugs.webkit.org/attachment.cgi?id=130082&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130082&action=review


This seems like a good idea., the trade off looks very reasonable. Let's see
how that perform in the wild :)

> Source/WebCore/ChangeLog:13
> +	   In my local Mac environment, this optimization improves the
performance
> +	   of CSS property getters by 35%, and the performance of CSS property
setters
> +	   by 8%.

Are those numbers still accurate after your update?

> Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:183
> +    typedef HashMap<String, CSSPropertyInfo> CSSPropertyInfoMap;
> +    DEFINE_STATIC_LOCAL(CSSPropertyInfoMap, map, ());
> +    propertyInfo = map.get(stringForCache);

I would prefer propertyInfoCache or something more descriptive instead of map.