[webkit-reviews] review granted: [Bug 80120] Change the argument orders to match OpenGL's in GraphicsContext3D functions : [Attachment 130017] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Changhun Kang
<temoochin at company100.net>'s request for review:
Bug 80120: Change the argument orders to match OpenGL's in GraphicsContext3D
functions
https://bugs.webkit.org/show_bug.cgi?id=80120

Attachment 130017: Patch
https://bugs.webkit.org/attachment.cgi?id=130017&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130017&action=review


The code looks fine; the ChangeLogs need to be updated. r=me, but you'll need
to upload a new patch.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

You'll have to remove this line in order for the commit queue to accept this
patch. Leave the one above about "Reviewed by NOBODY".

> Source/WebCore/ChangeLog:71
> +2012-03-03  Changhun Kang  <temoochin at company100.net>

This duplicate ChangeLog entry needs to be removed.

> Source/WebCore/ChangeLog:141
> +2012-03-03  Changhun Kang  <temoochin at company100.net>

And this one and throughout this patch.