[webkit-reviews] review denied: [Bug 88665] Favicon URL list sent with favicon updated message contains out of date icon URLs : [Attachment 146608] Patch with a proposed fix for the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 16:07:56 PDT 2012


Brady Eidson <beidson at apple.com> has denied Pete Williamson
<petewil at chromium.org>'s request for review:
Bug 88665: Favicon URL list sent with favicon updated message contains out of
date icon URLs
https://bugs.webkit.org/show_bug.cgi?id=88665

Attachment 146608: Patch with a proposed fix for the bug
https://bugs.webkit.org/attachment.cgi?id=146608&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
We historically have not supported dynamic changing of the icon very well,
almost intentionally.

If we are going to start supporting this and expect to continue supporting it
*consistently*, then I'm afraid you have the burden of being the first one to
write regression tests that are capable of capturing the expectations.


More information about the webkit-reviews mailing list