[webkit-reviews] review requested: [Bug 70103] [chromium] Implement position:fixed in compositor thread : [Attachment 146659] Again from scratch, tested and still feels solid

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 16:07:46 PDT 2012


Shawn Singh <shawnsingh at chromium.org> has asked  for review:
Bug 70103: [chromium] Implement position:fixed in compositor thread
https://bugs.webkit.org/show_bug.cgi?id=70103

Attachment 146659: Again from scratch, tested and still feels solid
https://bugs.webkit.org/attachment.cgi?id=146659&action=review

------- Additional Comments from Shawn Singh <shawnsingh at chromium.org>
Vangelis and I had another discusison about this and decided to try seeing what
it would look like if we computed scrollCompensation in the recursion itself.
It works just as well as the previous patch, just a different algorithm. It
does seem like less scary code, but I think it depends on who you ask whether
its actually more complicated or less complicated =) At any rate, both this
patch and the previous one should work equally well, whichever one reviewers
like better is fine with me. Thanks!


More information about the webkit-reviews mailing list