[webkit-reviews] review granted: [Bug 80597] [WK2] Add WKHitTestResultIsContentEditable() : [Attachment 130824] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 80597: [WK2] Add WKHitTestResultIsContentEditable()
https://bugs.webkit.org/show_bug.cgi?id=80597

Attachment 130824: Patch
https://bugs.webkit.org/attachment.cgi?id=130824&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130824&action=review


Normally I would not review patches that affect the C WebKit API, but this
patch has been sitting for a very long time with no input. The API makes a lot
of sense to me, but given that the WebKit2 team hasn't really chimed in, I
think it's better to make this API private when landing. You can just move the
new API to Source/WebKit2/UIProcess/API/C/WKHitTestResultPrivate.h.

> Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp:360
> + * Returns: %TRUE if there's an editable element in the coordinates of the
Hit Test,

Maybe @hit_test_result would be better than " the Hit Test"

Should probably say "at the coordinates" instead of "in the coordinates"