[webkit-reviews] review denied: [Bug 77300] Pacify clang shared_library build by leaking a global static. : [Attachment 124473] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 30 09:45:19 PST 2012


Tony Chang <tony at chromium.org> has denied Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 77300: Pacify clang shared_library build by leaking a global static.
https://bugs.webkit.org/show_bug.cgi?id=77300

Attachment 124473: Patch
https://bugs.webkit.org/attachment.cgi?id=124473&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124473&action=review


> Source/WebKit/chromium/tests/TextureManagerTest.cpp:42
> -FakeTextureAllocator fakeTextureAllocator;
> +DEFINE_STATIC_LOCAL(FakeTextureAllocator, fakeTextureAllocator, ());

Can we move this into the requestTexture function?  That appears to be the only
place it's used.


More information about the webkit-reviews mailing list