[webkit-reviews] review granted: [Bug 77112] If the QTDIR environment variable is set, the build system fails to compile WinCairo : [Attachment 124522] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 77112: If the QTDIR environment variable is set, the build system fails to
compile WinCairo
https://bugs.webkit.org/show_bug.cgi?id=77112

Attachment 124522: Patch
https://bugs.webkit.org/attachment.cgi?id=124522&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124522&action=review


> Tools/Scripts/webkitdirs.pm:882
>      # The presence of QTDIR only means Qt if --gtk or --wx or --efl or
--blackberry or --chromium are not on the command-line

This comment should be updated to mention that we ignore the QTDIR environment
variable when --wincairo is specified on the command line.

On another note, this exclusion list of ports is long. Maybe we should consider
only building for Qt when the --qt command line option is explicitly specified.
That is, don't check for a set QTDIR environment variable.