[webkit-reviews] review granted: [Bug 77085] [GStreamer] 0.11 build support : [Attachment 124089] 0.11 build support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 30 09:48:33 PST 2012
Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 77085: [GStreamer] 0.11 build support
https://bugs.webkit.org/show_bug.cgi?id=77085
Attachment 124089: 0.11 build support
https://bugs.webkit.org/attachment.cgi?id=124089&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124089&action=review
Looks good, but fix the indentation and line breaking of the case statement.
> configure.ac:272
> +# determine the (optional) GStreamer version to use
You can just omit this.
> configure.ac:277
> + [case "$with_gstreamer" in
> + 0.10|0.11) ;;
Your line breaks and indentation are a bit weird here.
More information about the webkit-reviews
mailing list