[webkit-reviews] review granted: [Bug 76764] run-perf-tests ignore Skipped list on chromium : [Attachment 123505] fixes the bug

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 76764: run-perf-tests ignore Skipped list on chromium
https://bugs.webkit.org/show_bug.cgi?id=76764

Attachment 123505: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=123505&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
I think this change is fine. While I agree with the general "god" sentiment
about the Port class, it's not at all clear what the right way to factor out
logic is here, and creating a class just for parsing Skipped files itself would
be silly.

I think perhaps a separate change that moved all of the expectations-related
logic out might be good, but I don't really want to make that a blocker of this
and I'd want to think about that more.