[webkit-reviews] review granted: [Bug 74874] REGRESSION (r102040): Wrong column widths when row has colspan and unwrappable text : [Attachment 123590] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 74874: REGRESSION (r102040): Wrong column widths when row has colspan and
unwrappable text
https://bugs.webkit.org/show_bug.cgi?id=74874

Attachment 123590: Patch
https://bugs.webkit.org/attachment.cgi?id=123590&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123590&action=review


The patch does not apply on ToT because your win expectation file change needs
to be rebased.

> LayoutTests/ChangeLog:18
> +	   * platform/chromium-linux/fast/table/027-expected.png:
> +	     1 px difference - benign
> +	   * platform/chromium-linux/fast/table/027-vertical-expected.png:
> +	     This is a progression - previously the image in the last cell was
> +	     extruding from the table in a 800x600 view.

Nit: Spaces would make those 2 comments stand out more.

> LayoutTests/platform/mac/test_expectations.txt:201
> +BUGWK74874 : fast/table/027.html = TEXT
> +BUGWK74874 : fast/table/027-vertical.html = TEXT

Unless I am missing something, this should also be TEXT+IMAGE as you haven't
rebaselined Mac in this patch.