[webkit-reviews] review denied: [Bug 76459] Make shouldLayoutFixedElementsRelativeToFrame a setting : [Attachment 123369] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 13:40:04 PST 2012


MORITA Hajime <morrita at google.com> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 76459: Make shouldLayoutFixedElementsRelativeToFrame a setting
https://bugs.webkit.org/show_bug.cgi?id=76459

Attachment 123369: Patch
https://bugs.webkit.org/attachment.cgi?id=123369&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123369&action=review


Please fix the build breakage on gtk and win. It looks a real failure.

> Source/WebCore/page/Settings.h:631
> +	   bool m_shouldLayoutFixedElementsRelativeToFrame : 1;

Please add an initializer for this value in the constructor.


More information about the webkit-reviews mailing list