[webkit-reviews] review denied: [Bug 76706] Web Inspector: Make "Copy as HTML" use the same copy functions as other copy methods. : [Attachment 123334] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Konrad Piascik
<kpiascik at rim.com>'s request for review:
Bug 76706: Web Inspector: Make "Copy as HTML" use the same copy functions as
other copy methods.
https://bugs.webkit.org/show_bug.cgi?id=76706

Attachment 123334: patch
https://bugs.webkit.org/attachment.cgi?id=123334&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123334&action=review


> Source/WebCore/inspector/front-end/ElementsPanel.js:937
> +	   var copy = function(id, text) {

As I mentioned in the previous review:

- we only use named functions
- { should be on the next line
- this is not "id", this is "error" string

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:-1687
> -	   this.representedObject.copyNode();

It sounds like you could leave implementation of copyNode in DOMAgent given
that there are multiple call sites.