[webkit-reviews] review granted: [Bug 76813] Web Inspector: DetailedHeapSnapshot: Replace the list of retainers with the expandable tree (to get rid of cycles) : [Attachment 123527] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 76813: Web Inspector: DetailedHeapSnapshot: Replace the list of retainers
with the expandable tree (to get rid of cycles)
https://bugs.webkit.org/show_bug.cgi?id=76813

Attachment 123527: Patch
https://bugs.webkit.org/attachment.cgi?id=123527&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123527&action=review


Looks sane.

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:194
> +    },

trailing comma

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:462
> +    retainingPathsTitle.textContent = WebInspector.UIString("Object's
retaining tree");

Please bring localized strings in sync with the change.