[webkit-reviews] review denied: [Bug 76705] Web Inspector: IndexedDBModel should keep track of requests sent to the backend. : [Attachment 123333] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 01:08:00 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 76705: Web Inspector: IndexedDBModel should keep track of requests sent to
the backend.
https://bugs.webkit.org/show_bug.cgi?id=76705

Attachment 123333: Patch
https://bugs.webkit.org/attachment.cgi?id=123333&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123333&action=review


> Source/WebCore/inspector/front-end/IndexedDBModel.js:255
>  WebInspector.IndexedDBDispatcher.prototype = {

We try to keep the logic either in the dispather or in the model. In your case,
model is preferred. I'd suggest to make dispatcher a pure delegate.


More information about the webkit-reviews mailing list