[webkit-reviews] review granted: [Bug 75652] Inconsistent text selection behavior with option-shift-left/right : [Attachment 122051] fixed review comments from enrica

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 75652: Inconsistent text selection behavior with option-shift-left/right
https://bugs.webkit.org/show_bug.cgi?id=75652

Attachment 122051: fixed review comments from enrica
https://bugs.webkit.org/attachment.cgi?id=122051&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122051&action=review


r=me provided nits below are fixed.

> Source/WebCore/editing/FrameSelection.cpp:946
> +	       VisibleSelection newSelection(m_selection);

We prefer newSelection = m_selection over newSelection(m_selection).

>
LayoutTests/editing/selection/selection-extend-should-not-move-across-caret-on-
mac.html:21
> +    function editingTest(behavior) {
> +	   if (window.layoutTestController) {
> +	       layoutTestController.dumpAsText();
> +	       layoutTestController.setEditingBehavior(behavior);
> +	   }

It seems redundant to indent the entire contents inside <script>.