[webkit-reviews] review granted: [Bug 75088] [Qt] Consolidate layout test crash logging : [Attachment 122743] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 17 11:07:07 PST 2012
Simon Hausmann <hausmann at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 75088: [Qt] Consolidate layout test crash logging
https://bugs.webkit.org/show_bug.cgi?id=75088
Attachment 122743: Patch
https://bugs.webkit.org/attachment.cgi?id=122743&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122743&action=review
r=me, but please fix the style issue and add the missing "static" before
landing.
> Source/JavaScriptCore/wtf/Assertions.cpp:328
> +WTFCrashHookFunction globalHook = 0;
Missing static?
More information about the webkit-reviews
mailing list