[webkit-reviews] review denied: [Bug 76381] Use precompiled headers in Chromium port on Windows : [Attachment 122645] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Jói Sigurðsson <joi at chromium.org>'s
request for review:
Bug 76381: Use precompiled headers in Chromium port on Windows
https://bugs.webkit.org/show_bug.cgi?id=76381

Attachment 122645: Patch
https://bugs.webkit.org/attachment.cgi?id=122645&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122645&action=review


Seems fine, just some minor nits.

I'm not sold on the directory Source/gyp/* for these files because chromium
currently doesn't use either file in Source/gyp, but maybe that's OK.  Maybe
abarth has a better suggestion.

> Source/gyp/WinPrecompile.cpp:35
> + */

The svn:executable bit appears to be set on all these files.

> Source/gyp/WinPrecompile.gypi:37
> +  'conditions': [
> +    ['OS=="win" and chromium_win_pch==1', {
> +	   'variables': {
> +	       'conditions': [

Nit: This is a mix of 2 space and 4 space indents.  I would use 4 space indents
since that's more consistent with the rest of WebKit.

> Source/gyp/WinPrecompile.gypi:41
> +		   # We need to calculate the path to the gyp directory
> +		   # differently depending on whether we are being built
> +		   # stand-alone (via build-webkit --chromium) or as part
> +		   # of the Chromium checkout.

80 column line limit doesn't exist in webKit so feel free to unwrap this
comment into 2 lines or so.