[webkit-reviews] review granted: [Bug 103929] Disable WebKit2 api tests on Apple Windows port : [Attachment 177358] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 15:54:40 PST 2012


Tim Horton <timothy_horton at apple.com> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 103929: Disable WebKit2 api tests on Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=103929

Attachment 177358: patch
https://bugs.webkit.org/attachment.cgi?id=177358&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177358&action=review


> Tools/Scripts/run-api-tests:276
> +	  } elsif (!isAppleWinWebKit() || $suite !~ m/WebKit2*/) {
> +	     # Disabling WebKit2 API test on Windows since we will be disabling
WebKit2 on Windows.

A little wacky but better, but maybe use next to make it less wacky.


More information about the webkit-reviews mailing list