[webkit-reviews] review denied: [Bug 103937] [chromium] fix showFPScounter and showPaintRects not toggleable after page change : [Attachment 177348] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied egraether at chromium.org's
request for review:
Bug 103937: [chromium] fix showFPScounter and showPaintRects not toggleable
after page change
https://bugs.webkit.org/show_bug.cgi?id=103937

Attachment 177348: Patch
https://bugs.webkit.org/attachment.cgi?id=177348&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177348&action=review


This patch looks good (except for InspectorPageAgent interaction from within
WebKit). There are two other ways it could be implemented: 1) finding a signal
that would reliably trigger after layer tree is there from within WebCore or 2)
creating such a signal.

> Source/WebKit/chromium/src/WebViewImpl.cpp:4048
> +#if ENABLE(INSPECTOR)

chromium === ENABLE(INSPECTOR)

> Source/WebKit/chromium/src/WebViewImpl.cpp:4049
> +	       InspectorPageAgent* pageAgent =
page()->inspectorController()->pageAgent();

You can only talk to InspectorController from WebKit layer.