[webkit-reviews] review granted: [Bug 103642] Add support for generic types in arrays and sequences to the code generators : [Attachment 177263] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 3 15:54:39 PST 2012
Kentaro Hara <haraken at chromium.org> has granted Adam Bergkvist
<adam.bergkvist at ericsson.com>'s request for review:
Bug 103642: Add support for generic types in arrays and sequences to the code
generators
https://bugs.webkit.org/show_bug.cgi?id=103642
Attachment 177263: Updated patch
https://bugs.webkit.org/attachment.cgi?id=177263&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177263&action=review
Looks good to me.
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3076
> +sub GetNativeInnerVectorType
Shall we rename it to GetRefPtrNativeType() ?
More information about the webkit-reviews
mailing list