[webkit-reviews] review granted: [Bug 81263] [CSS Filters] Drop-shadow and blur can avoid using full source image : [Attachment 137638] Patch V1

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 81263: [CSS Filters] Drop-shadow and blur can avoid using full source image
https://bugs.webkit.org/show_bug.cgi?id=81263

Attachment 137638: Patch V1
https://bugs.webkit.org/attachment.cgi?id=137638&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137638&action=review


Just one small question on naming, and some typos.

> Source/WebCore/ChangeLog:10
> +	   Even if the element is completely offscreen, but it's shadow is in
the viewport, we can still compute the source 

typo it's -> its

> Source/WebCore/ChangeLog:14
> +	   No new tests, this change doesn't have visible results and the
functionality should
> +	   already be covered by previous filter tests.

We couldn't have a repaint test specifically for this?	I'm not worried if not.


> Source/WebCore/rendering/FilterEffectRenderer.cpp:370
> +	   // Note that the outsets are reveresed here because we are going
backwards -> we have the dirty rect and

Typo - reveresed -> reversed.

> Source/WebCore/rendering/FilterEffectRenderer.cpp:379
> +bool FilterEffectRendererHelper::prepareFilterEffect(RenderLayer*
renderLayer, const LayoutRect& filterBoxRect, const LayoutRect& dirtyRect,
const LayoutRect& layerRepaintRect)

Unless I'm missing something, but this method no longer calls prepare(), so
maybe it should be renamed?