[webkit-reviews] review granted: [Bug 84175] Change RenderThemeChromiumSkia paint methods to use pixel snapping : [Attachment 137630] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 17 16:59:48 PDT 2012


Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 84175: Change RenderThemeChromiumSkia paint methods to use pixel snapping
https://bugs.webkit.org/show_bug.cgi?id=84175

Attachment 137630: Patch
https://bugs.webkit.org/attachment.cgi?id=137630&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137630&action=review


> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:286
> +    LayoutUnit cancelButtonSize = std::min(inputContentBox.width(),
std::min(inputContentBox.height(), r.height()));

Don't we normally have "using namespace std;" at the top of cpp files which
need min/max?


More information about the webkit-reviews mailing list