[webkit-reviews] review denied: [Bug 84211] Add default constructor for CSSImageSetValue::ImageWithScale. : [Attachment 137634] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 17 17:17:11 PDT 2012
Sam Weinig <sam at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 84211: Add default constructor for CSSImageSetValue::ImageWithScale.
https://bugs.webkit.org/show_bug.cgi?id=84211
Attachment 137634: Patch
https://bugs.webkit.org/attachment.cgi?id=137634&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
I don't think this adds any real benefit. THe initialization of imageURL is
also completely unnecessary, as String has a default initialization already.
If there is a case where we are using this uninitialized, we should probably
fix it at the call site.
More information about the webkit-reviews
mailing list