[webkit-reviews] review denied: [Bug 77520] [WK2] Modify parameters of willSubmitForm callback : [Attachment 137062] updated patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 77520: [WK2] Modify parameters of willSubmitForm callback
https://bugs.webkit.org/show_bug.cgi?id=77520

Attachment 137062: updated patch
https://bugs.webkit.org/attachment.cgi?id=137062&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137062&action=review


This seems like a bad idea, and too expensive for the general case.  The bundle
can be used to annotate the callback with this data if it necessary.

> Source/WebKit2/UIProcess/API/C/WKPage.h:140
> +typedef void (*WKPageWillSubmitFormCallback)(WKPageRef page, WKFrameRef
frame, WKFrameRef sourceFrame, WKArrayRef textFieldsProperties, WKDictionaryRef
formAttributes, WKTypeRef userData, WKFormSubmissionListenerRef listener, const
void* clientInfo);

This will break existing clients.  You can;t just change delegates like this,
you need to version it.