[webkit-reviews] review granted: [Bug 83545] Stack overflow in CSS parser caused by recursive stylesheet import : [Attachment 136585] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted David Barr
<davidbarr at chromium.org>'s request for review:
Bug 83545: Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545

Attachment 136585: Patch
https://bugs.webkit.org/attachment.cgi?id=136585&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136585&action=review


I think this patch is a progression and landable as is although there are cases
where this patch won't adequately address.

e.g. say we have <link href="redirection1.css"> then redirection1.css would
redirect us to redirection2.css then again to actual.css.
we can then encounter <link href="redirection2.css">, which then redirect again
to actual.css. But fixing this bug in general requires making http requests,
etc... so it should probably be fixed in a separate patch.

> LayoutTests/http/tests/css/css-imports-redirect-cycle.html:1
> +<script>

Do we really want to use quirks mode?