[webkit-reviews] review denied: [Bug 82664] Need DOMWindow mechanism to supplement UserScripts for page cache notifications : [Attachment 136466] Patch v5 - More project file additions

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 82664: Need DOMWindow mechanism to supplement UserScripts for page cache
notifications
https://bugs.webkit.org/show_bug.cgi?id=82664

Attachment 136466: Patch v5 - More project file additions
https://bugs.webkit.org/attachment.cgi?id=136466&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136466&action=review


Looking better, still needs some work.

> Source/WebCore/loader/FrameLoaderClient.h:336
> +	   virtual void dispatchCanCreateGlobalObject(DOMWrapperWorld*) { }

I don't really understand the naming here.  The client can't really create a
global object can it?

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageGroup.h:50
> +    WKBundlePageGroupDidCreateGlobalObjectForFrameCallback		       
   didCreateGlobalObjectForFrame;
> +   
WKBundlePageGroupWillDisconnectDOMWindowExtensionFromGlobalObjectCallback  
willDisconnectDOMWindowExtensionFromGlobalObject;
> +    WKBundlePageGroupDidReconnectDOMWindowExtensionToGlobalObjectCallback   
   didReconnectDOMWindowExtensionToGlobalObject;
> +    WKBundlePageGroupWillDestroyGlobalObjectForDOMWindowExtensionCallback   
   willDestroyGlobalObjectForDOMWindowExtension;
> +};

I think these should go on the BundlePageLoadClient as discussed.