[webkit-reviews] review canceled: [Bug 81786] Initial support fixed position elements in Qt WebKit2 : [Attachment 135972] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 8 13:34:30 PDT 2012

Yael <yael.aharon at nokia.com> has canceled Yael <yael.aharon at nokia.com>'s
request for review:
Bug 81786: Initial support fixed position elements in Qt WebKit2

Attachment 135972: Patch.

------- Additional Comments from Yael <yael.aharon at nokia.com>
Address comment #43, except for the change in FrameView.cpp.

> > Source/WebCore/page/FrameView.cpp:1707
> > +	     if
> > +		 updateFixedElementsAfterScrolling();
> Maybe we should do the check inside the method instead?

The default in chromium is to not create a graphics layer for fixed elements
and moving the check will effectively revert
http://trac.webkit.org/changeset/111139 .

More information about the webkit-reviews mailing list