[webkit-reviews] review requested: [Bug 81786] Initial support fixed position elements in Qt WebKit2 : [Attachment 136157] Patch

[bugzilla-daemon at webkit.org]

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 81786: Initial support fixed position elements in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=81786

Attachment 136157: Patch
https://bugs.webkit.org/attachment.cgi?id=136157&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Address comment #43, except for the change in FrameView.cpp.

> > Source/WebCore/page/FrameView.cpp:1707
> > +	     if
(m_frame->page()->settings()->acceleratedCompositingForFixedPositionEnabled())
> > +		 updateFixedElementsAfterScrolling();
> 
> Maybe we should do the check inside the method instead?

The default in chromium is to not create a graphics layer for fixed elements
and moving the check will effectively revert
http://trac.webkit.org/changeset/111139 .