[webkit-reviews] review granted: [Bug 83437] Command-line jsc's exception handling should be rationalized : [Attachment 136156] the patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Filip Pizlo <fpizlo at apple.com>'s request for
review:
Bug 83437: Command-line jsc's exception handling should be rationalized
https://bugs.webkit.org/show_bug.cgi?id=83437

Attachment 136156: the patch
https://bugs.webkit.org/attachment.cgi?id=136156&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=136156&action=review


> Source/JavaScriptCore/jsc.cpp:532
>	   if (dump) {
> -	       if (evaluationException)
> -		   printf("Exception: %s\n",
evaluationException.toString(globalObject->globalExec())->value(globalObject->g
lobalExec()).utf8().data());
> -	       else
> +	       if (!evaluationException)

Now that there’s no else clause inside you can just write
    if (dump && !evaluationException)