[webkit-reviews] review granted: [Bug 71678] [chromium] MediaStream API: Adding embedding code for GetUserMedia : [Attachment 116110] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tommy
Widenflycht <tommyw at google.com>'s request for review:
Bug 71678: [chromium] MediaStream API: Adding embedding code for GetUserMedia
https://bugs.webkit.org/show_bug.cgi?id=71678

Attachment 116110: Patch
https://bugs.webkit.org/attachment.cgi?id=116110&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116110&action=review


> Source/WebKit/chromium/src/UserMediaClientImpl.cpp:14
> + * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY

nit: this copyright notice incorrectly says that this software is provided by
"APPLE"

I think you should switch "APPLE" to "GOOGLE" here, and in the other newly
added files.

> Source/WebKit/chromium/src/UserMediaClientImpl.h:47
> +    virtual void pageDestroyed();

nit: Maybe we can delete UserMediaClient::pageDestroyed now?