[webkit-reviews] review denied: [Bug 70484] [WK2] add flag to only check pixel results if png files exist : [Attachment 116019] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Fehér Zsolt
<feherzs at inf.u-szeged.hu>'s request for review:
Bug 70484: [WK2] add flag to only check pixel results if png files exist
https://bugs.webkit.org/show_bug.cgi?id=70484

Attachment 116019: Patch
https://bugs.webkit.org/attachment.cgi?id=116019&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116019&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:113
> +		   if
skip_pixel_test_if_no_baseline.skip_pixel_test(self._port,
test_input.test_name):

Can't you just replace this with:

test_input.should_run_pixel_test = (port.expected_image(test_name) == None)

and delete skip_pixel_test_if_no_baseline.py ?

Also, I still don't understand why you are limiting this flag to
WebKitTestRunner. It doesn't seem like anything will break if you run this on
other ports?

> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:159
> +	       if skip_pixel_test_if_no_baseline.skip_pixel_test(port,
test_name):

I suggest you just inline the function here as well.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:69
> +	       return -1

As I suggested above, I don't think this check is necessary.