[webkit-reviews] review denied: [Bug 69750] NRWT should handle duplicated expectations : [Attachment 114218] proposed fix with unit test

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 69750: NRWT should handle duplicated expectations
https://bugs.webkit.org/show_bug.cgi?id=69750

Attachment 114218: proposed fix with unit test
https://bugs.webkit.org/attachment.cgi?id=114218&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114218&action=review


Sorry, I'm not sure how this fell off of my plate.

Almost there, I would just simplify the unit test a bit.

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:269
> +	   self.assertEqual(logs_string, 'The fast/foo/bar.html test from
test_expectations.txt in line 2 is also in Skipped!\n')

I don't usually test for exact string matches on the error messages; that makes
the tests fragile. I would just test that parsing the expectations raises a
ParseError, as in test_overrides__duplicate on line 226.