[webkit-reviews] review denied: [Bug 60797] Fix regressions from r86447 : [Attachment 93501] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Robert Hogan
<robert at webkit.org>'s request for review:
Bug 60797: Fix regressions from r86447
https://bugs.webkit.org/show_bug.cgi?id=60797

Attachment 93501: Patch
https://bugs.webkit.org/attachment.cgi?id=93501&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93501&action=review

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:177
> +	   m_eventSenderWebView = new QWebView(0);

This view is leaked.

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:1121
> +    // that is just enough to allow EventSender to install an event filter.
> +    // We use a new (dummy) QWebView so that we don't interfere
> +    // with the EventSender on the main page.
> +    DumpRenderTreeSupportQt::setView(page,
static_cast<WebPage*>(page)->eventSenderWebView());

I guess you could simply create the view here, so you can use the container for
handling the memory.

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.h:187
> +    QWebView* eventSenderWebView();

This is not really the event sender WebView, it is just the main view of the
page. I would rather have a name that does not mention eventSender.