[webkit-reviews] review denied: [Bug 60779] Bug in rubber banding logic for scroll animators : [Attachment 93478] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Jon Lee <jonlee at apple.com>'s request
for review:
Bug 60779: Bug in rubber banding logic for scroll animators
https://bugs.webkit.org/show_bug.cgi?id=60779

Attachment 93478: Patch
https://bugs.webkit.org/attachment.cgi?id=93478&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93478&action=review

Noticed the word coalesced spelled with two l's as "coalesced" in a few places.


> Source/WebCore/page/ChromeClient.h:173
> +	   virtual bool shouldRubberBandInDirection(ScrollDirection) = 0;

These will need to be reimplemented for many platforms. That’s why the build of
every platform except for Mac is failing.

>> Source/WebCore/page/ChromeClient.h:324
>> +	    virtual void updateCountWheelEventHandlers(unsigned) = 0;
> 
> This sounds like you want the callee to update their count. I think it's
really 'numWheelEventHandlersChanged()', no?

These will need to be reimplemented for many platforms. That’s why the build of
every platform except for Mac is failing.

This name should probably be setWheelEventHandlerCount.