[webkit-reviews] review requested: [Bug 60770] QtWebKit bridge assignToHTMLImageElement() results in invalid Image : [Attachment 93505] set CachedImage response URL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 13 14:02:55 PDT 2011


Andrew Wason <rectalogic at rectalogic.com> has asked  for review:
Bug 60770: QtWebKit bridge assignToHTMLImageElement() results in invalid Image
https://bugs.webkit.org/show_bug.cgi?id=60770

Attachment 93505: set CachedImage response URL
https://bugs.webkit.org/attachment.cgi?id=93505&action=review

------- Additional Comments from Andrew Wason <rectalogic at rectalogic.com>
Attached patch fixes this by allowing an optional URL to be passed to
CachedImage constructor, and this is set on the ResourceResponse. The Qt bridge
is changed to construct the image with a qrc:/assignedImage url.

An alternative would be to change the test in
WebGLRenderingContext::validateHTMLImageElement, but I'm not sure what a valid
test would be.


More information about the webkit-reviews mailing list