[webkit-reviews] review denied: [Bug 50521] [Qt] Improper rendering of <button> tag when it contains a <br> : [Attachment 85084] proposed patch v3

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Dawit A. <adawit at kde.org>'s
request for review:
Bug 50521: [Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521

Attachment 85084: proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=85084&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85084&action=review

> Source/WebCore/ChangeLog:7
> +

Please explain your change here. This change is not trivial, even if short.
Explaining what is wrong and how your change fix it is useful for future
reference when modifying this file.

> Source/WebCore/platform/qt/RenderThemeQt.cpp:516
>      // FIXME: Check is flawed, since it doesn't take min-width/max-width
into account.

Is this FIXME still valid with your change?