[webkit-reviews] review requested: [Bug 56304] REGRESSION(r80892): 100, 000+ leaks seen on the build bot : [Attachment 85668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 05:24:31 PDT 2011


Mark Rowe (bdash) <mrowe at apple.com> has asked  for review:
Bug 56304: REGRESSION(r80892): 100,000+ leaks seen on the build bot
https://bugs.webkit.org/show_bug.cgi?id=56304

Attachment 85668: Patch
https://bugs.webkit.org/attachment.cgi?id=85668&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The explicit calls to StringImpl::ref seem as though they will also result in
leaks as there are no matching calls to StringImpl::deref anywhere.  The patch
removes those as well as fixing the bigger issue of the leaked duplicate
entries.


More information about the webkit-reviews mailing list