[webkit-reviews] review granted: [Bug 56123] Web Inspector: move breakpoints restoring to debugger presentation model : [Attachment 85352] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 56123: Web Inspector: move breakpoints restoring to debugger presentation
model
https://bugs.webkit.org/show_bug.cgi?id=56123

Attachment 85352: Patch.
https://bugs.webkit.org/attachment.cgi?id=85352&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85352&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:51
> +	       this._breakpointsRestored = true;

debugger is enabled with no state, we should restore breakpoints in all cases.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:60
> +	       if (id in this._breakpoints)

this._uiBreakpoints

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:196
> +	       if (typeof breakpoint.url !== "string" || typeof
breakpoint.lineNumber !== "number" || typeof breakpoint.columnNumber !==
"number" ||

How can this happen?