[webkit-reviews] review denied: [Bug 55822] Web Inspector: move breakpoints filtering to debugger model : [Attachment 84860] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 6 10:59:08 PST 2011
Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55822: Web Inspector: move breakpoints filtering to debugger model
https://bugs.webkit.org/show_bug.cgi?id=55822
Attachment 84860: Patch.
https://bugs.webkit.org/attachment.cgi?id=84860&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84860&action=review
> Source/WebCore/inspector/front-end/DebuggerModel.js:333
> +
this.dispatchEventToListeners(WebInspector.DebuggerModel.Events.BreakpointAdded
, breakpoint);
What happens if breakpoint is not resolved or is resolved on a different line?
Should it get BreakpointAdded event? Do we have an "unresolved" breakpoint
state?
More information about the webkit-reviews
mailing list