[webkit-reviews] review canceled: [Bug 55821] Web Inspector: move breakpoint column adjustment to debugger model : [Attachment 84859] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 6 11:07:11 PST 2011
Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55821: Web Inspector: move breakpoint column adjustment to debugger model
https://bugs.webkit.org/show_bug.cgi?id=55821
Attachment 84859: Patch.
https://bugs.webkit.org/attachment.cgi?id=84859&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84859&action=review
> Source/WebCore/inspector/front-end/DebuggerModel.js:83
> + var script = this._scripts[id];
So you rely upon the fact that _scripts are sorted in the compilation order,
right?
This is right, but a bit fragile. Could you mention it in the comments and
provide a test? Clearing r? while waiting for test.
> Source/WebCore/inspector/front-end/DebuggerModel.js:100
> + }
Please revert this change.
More information about the webkit-reviews
mailing list