[webkit-reviews] review denied: [Bug 44311] Web Inspector: elements dom tree - word wrap toggle : [Attachment 84861] [PATCH] Suggested solution

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 44311: Web Inspector: elements dom tree - word wrap toggle
https://bugs.webkit.org/show_bug.cgi?id=44311

Attachment 84861: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=84861&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84861&action=review

Did you check whether revealing element reveals it horizontally Ok?

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:196
> +	   var x = Math.max(Math.min(root.totalOffsetLeft + root.offsetWidth,
root.parentElement.totalOffsetLeft + root.parentElement.offsetWidth) - 20, 1);

Could you use wrap / nowrap conditions here and simplify the code? r- for this.