[webkit-reviews] review denied: [Bug 55823] Web Inspector: re-implement breakpoints sidebar pane as a simple ui component. : [Attachment 84863] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 6 10:50:25 PST 2011
Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55823: Web Inspector: re-implement breakpoints sidebar pane as a simple ui
component.
https://bugs.webkit.org/show_bug.cgi?id=55823
Attachment 84863: Patch.
https://bugs.webkit.org/attachment.cgi?id=84863&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84863&action=review
> Source/WebCore/inspector/front-end/ScriptsPanel.js:1056
> + _javaScriptBreakpointsSidebarPaneBreakpointClicked: function(event)
I think the code would be much cleaner if you had a Breakpoint class with
corresponding methods on it. Did you consider this option? It would also result
it way less changes.
More information about the webkit-reviews
mailing list