[webkit-reviews] review denied: [Bug 55825] Web Inspector: remove groupName from objectId : [Attachment 84865] [patch] initial version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 55825: Web Inspector: remove groupName from objectId
https://bugs.webkit.org/show_bug.cgi?id=55825

Attachment 84865: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=84865&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84865&action=review

> Source/WebCore/ChangeLog:9
> +	   ():

Please remove these from ChangeLog.

> Source/WebCore/inspector/InjectedScriptSource.js:48
> +    this._idToObjectInfo = {};

Not all the objects have group names. I'd suggest that you simply create a
separate map for id -> groupName binding. Otherwise, overhead.