[webkit-reviews] review requested: [Bug 34959] [Qt] QtLauncher does not load the same set of fonts as the DRT : [Attachment 84867] This patch adds the option "-webkit-testfonts" to the QtTestBrowser.

[bugzilla-daemon at webkit.org]

Joe Wild <joseph.wild at nokia.com> has asked  for review:
Bug 34959: [Qt] QtLauncher does not load the same set of fonts as the DRT
https://bugs.webkit.org/show_bug.cgi?id=34959

Attachment 84867: This patch adds the option "-webkit-testfonts" to the
QtTestBrowser.
https://bugs.webkit.org/attachment.cgi?id=84867&action=review

------- Additional Comments from Joe Wild <joseph.wild at nokia.com>

This patch adds the option "-webkit-testfonts" to the QtTestBrowser.
When this option is used the webkit fonts are loaded the same
as they are in DumpRenderTree.	This option can be used on
QtTestBrowser and run-launcher.  It can only be used
on Linux systems with FcInit and is configured as such.

I have a couple of concerns with my changes.  Since I am reusing
the code from DumpRenderTree, I'm not sure of the best way to share
it.

I basically duplicated WebCore:DumpRenderTree::initializeFonts() from
in the QtTestBrowser since I did not want to reference files across
these separate components.

However, when initalizing the fonts, I am reading fonts.conf
from Tools/DumpRenderTree/qt/ since I did not want us to have
to maintain 2 copies of this file.

Finally, I changed the lookup of the fonts.conf to be relative from
the location of the QtTestBrowser executable instead of from the
WebKit top level directory as it does DumpRenderTree.  The main reason
for this is that run-launcher does not do a chdirWebKit() to the top
level directory, like run-webkit-tests does.  I'm not sure if this was
the right decision, but I did not want to change the behavior of the
run-launcher script.

I did not see any test or docs (other than QtTestBrowser -help) that
I needed to update.

Input welcome.