[webkit-reviews] review granted: [Bug 55824] Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles : [Attachment 84864] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 5 09:00:57 PST 2011
Pavel Feldman <pfeldman at chromium.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 55824: Web Inspector: [Chromium] Allow dynamic enabling of detailed heap
profiles
https://bugs.webkit.org/show_bug.cgi?id=55824
Attachment 84864: patch
https://bugs.webkit.org/attachment.cgi?id=84864&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks good except for Alexander's comment. Also, could you factor out this
shortcut handler as a separate method parametrized with the easter egg phrase?
More information about the webkit-reviews
mailing list