[webkit-reviews] review granted: [Bug 63360] fix possible race in LinkLoader : [Attachment 98551] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 63360: fix possible race in LinkLoader
https://bugs.webkit.org/show_bug.cgi?id=63360

Attachment 98551: Patch
https://bugs.webkit.org/attachment.cgi?id=98551&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98551&action=review

> Source/WebCore/loader/LinkLoader.cpp:62
> +void LinkLoader::linkLoadTimerFired(Timer<LinkLoader>* timer)

You should either omit the argument name, since it’s unused, or keep the
ASSERT_UNUSED.

> Source/WebCore/loader/LinkLoader.cpp:-63
> -    ASSERT_UNUSED(timer, timer == &m_linkLoadedTimer);

Why get rid of this?

> Source/WebCore/loader/LinkLoader.cpp:67
> +void LinkLoader::linkLoadingErrorTimerFired(Timer<LinkLoader>* timer)

You should either omit the argument name, since it’s unused, or use
ASSERT_UNUSED.